Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dataloader2 test targets #811

Closed
wants to merge 1 commit into from
Closed

Conversation

dahsh
Copy link
Contributor

@dahsh dahsh commented Oct 6, 2022

Summary:

  • To better track the test coverage of the data components, we make the dataloader2
    into a folder with a separate TARGETS.
  • We plan add the needed_coverage in the TARGETS after we solve the needed_coverage
    finding issue and make TARGETS of torchdata more modular.

Reviewed By: ejguan

Differential Revision: D40124125

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Oct 6, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40124125

Summary:
Pull Request resolved: pytorch#811

* To better track the test coverage of the data components, we make the dataloader2
 into a folder with a separate TARGETS.
* We plan add the needed_coverage in the TARGETS after we solve the needed_coverage
 finding issue and make TARGETS of torchdata more modular.

Reviewed By: ejguan

Differential Revision: D40124125

fbshipit-source-id: ac58fe4a6ba99ea194d1dff82cc926f68fc15b2b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40124125

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the tests are executed in OSS CI. Thank you

ejguan pushed a commit to ejguan/data that referenced this pull request Oct 23, 2022
Summary:
Pull Request resolved: pytorch#811

* To better track the test coverage of the data components, we make the dataloader2
 into a folder with a separate TARGETS.
* We plan add the needed_coverage in the TARGETS after we solve the needed_coverage
 finding issue and make TARGETS of torchdata more modular.

Reviewed By: ejguan

Differential Revision: D40124125

fbshipit-source-id: c096a7b7c4f02b82a865ea5276703506068f2e5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants