-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/n] DataLoader2 initial support for randomness control #801
Conversation
This pull request was exported from Phabricator. Differential Revision: D38947827 |
Summary: Pull Request resolved: pytorch#801 Add the initial support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - Change API of `ReadingService` to take seed generator from DataLoader2 Differential Revision: D38947827 fbshipit-source-id: 17db1e13fe8685f6b2817f72c0e199edfaf3a3a1
af3e476
to
eb4cdc4
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
Summary: Pull Request resolved: pytorch#801 Add the initial support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - Change API of `ReadingService` to take seed generator from DataLoader2 Differential Revision: D38947827 fbshipit-source-id: 5ae5065ab7aceb35e9f966c3d6bc585eb07c8ba5
eb4cdc4
to
53cbc2e
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
I might need to re-create a new PR via |
…vice (pytorch#801) Summary: Pull Request resolved: pytorch#801 Add the initial support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - Change API of `ReadingService` to take seed generator from DataLoader2 Reviewed By: Miiira Differential Revision: D38947827 fbshipit-source-id: 932cabdf1df5e0feafa44a3d2bc50c290360d323
53cbc2e
to
2bb8a96
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
…vice (pytorch#801) Summary: Pull Request resolved: pytorch#801 Add the initial support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - Change API of `ReadingService` to take seed generator from DataLoader2 Differential Revision: D38947827 fbshipit-source-id: 38cfc46ce3fbda6872a988fa27c072ff80d79c3c
2bb8a96
to
46dd635
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
…vice (pytorch#801) Summary: Pull Request resolved: pytorch#801 Add the initial support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - Change API of `ReadingService` to take seed generator from DataLoader2 Differential Revision: D38947827 fbshipit-source-id: fab10a21fecf76e9b5f5c2296fbf930c3af14d2d
This pull request was exported from Phabricator. Differential Revision: D38947827 |
46dd635
to
e0db329
Compare
…vice (pytorch#801) Summary: Pull Request resolved: pytorch#801 Add the initial support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - Change API of `ReadingService` to take seed generator from DataLoader2 Differential Revision: D38947827 fbshipit-source-id: c3018a408b78dd8d2e2858350edbb762ece10d37
e0db329
to
7a6d31b
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
…vice (pytorch#801) Summary: Pull Request resolved: pytorch#801 Add the initial support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - Change API of `ReadingService` to take seed generator from DataLoader2 Reviewed By: NivekT Differential Revision: D38947827 fbshipit-source-id: 21761db17cab2f1c9ef89058b6a53f53abe0590f
7a6d31b
to
d36a3ed
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
…vice (pytorch#801) Summary: Fixes pytorch#885 Pull Request resolved: pytorch#801 Add the support for DataLoader2 to control randomness over the pipeline: - Implement `SeedGenerator` - `spawn` to generate sub-SeedGenerators for distributed workers - `generate_seed` to generate unique seeds - `generate_shared_seed` to generate distributed shared seeds - Change API of `ReadingService` to take seed generator from DataLoader2. Then, the SeedGenerator of `DataLoader2` becomes the source of truth of randomness within the whole data pipeline. A separate PR will be added for online doc regarding determinism. Reviewed By: NivekT Differential Revision: D38947827 fbshipit-source-id: e1a434460b4a5d43461e982debe875808b4241db
d36a3ed
to
fb6b246
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Fixes pytorch#885 Add the support for DataLoader2 to control randomness over the pipeline: - Implement SeedGenerator - `spawn` to generate sub-SeedGenerators for distributed workers - `generate_seed` to generate unique seeds - `generate_shared_seed` to generate distributed shared seeds - Change API of ReadingService to take seed generator from DataLoader2. Then, the SeedGenerator of DataLoader2 becomes the source of truth of randomness within the whole data pipeline. A separate PR will be added for online doc regarding determinism. Last step for pytorch#885 Pull Request resolved: pytorch#801 Reviewed By: NivekT Differential Revision: D38947827 Pulled By: ejguan fbshipit-source-id: 006bf17cbb51b2d5a39d647ca86401b0483c7812
This pull request was exported from Phabricator. Differential Revision: D38947827 |
1e095ab
to
1ad11a0
Compare
Summary: Fixes pytorch#885 Add the support for DataLoader2 to control randomness over the pipeline: - Implement SeedGenerator - `spawn` to generate sub-SeedGenerators for distributed workers - `generate_seed` to generate unique seeds - `generate_shared_seed` to generate distributed shared seeds - Change API of ReadingService to take seed generator from DataLoader2. Then, the SeedGenerator of DataLoader2 becomes the source of truth of randomness within the whole data pipeline. A separate PR will be added for online doc regarding determinism. Last step for pytorch#885 Pull Request resolved: pytorch#801 Reviewed By: NivekT Differential Revision: D38947827 Pulled By: ejguan fbshipit-source-id: b6fa81de133a0613e8c96ce17b136d897ca80201
1ad11a0
to
b95c11e
Compare
This pull request was exported from Phabricator. Differential Revision: D38947827 |
Summary: Fixes pytorch#885 Add the support for DataLoader2 to control randomness over the pipeline: - Implement SeedGenerator - `spawn` to generate sub-SeedGenerators for distributed workers - `generate_seed` to generate unique seeds - `generate_shared_seed` to generate distributed shared seeds - Change API of ReadingService to take seed generator from DataLoader2. Then, the SeedGenerator of DataLoader2 becomes the source of truth of randomness within the whole data pipeline. A separate PR will be added for online doc regarding determinism. Last step for pytorch#885 Pull Request resolved: pytorch#801 Reviewed By: NivekT Differential Revision: D38947827 Pulled By: ejguan fbshipit-source-id: 2f852b89cb1d638e1b9222df838786eb8855afa4
This pull request was exported from Phabricator. Differential Revision: D38947827 |
b95c11e
to
bbe7a8c
Compare
Fixes #885
Add the support for DataLoader2 to control randomness over the pipeline:
spawn
to generate sub-SeedGenerators for distributed workersgenerate_seed
to generate unique seedsgenerate_shared_seed
to generate distributed shared seedsA separate PR will be added for online doc regarding determinism.
Differential Revision: D38947827
Last step for #885