Refactor to use traverse_dps instead of traverse
#793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Sep 27, 2022
ghstack-source-id: 121b33a125ab7675d828021ea1f12cc39e669276 Pull Request resolved: #793
facebook-github-bot
added
the
CLA Signed
NivekT
changed the title
traverse_dps instead of traverse
NivekT
requested review from
ejguan and
VitalyFedyunin
and removed request for
ejguan
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
approved these changes
Sep 27, 2022
|
There is a circular import issue. Let me have a look tomorrow. |
This should be merged only after pytorch/pytorch#85667 has been merged into nightly and internal. Differential Revision: [D39860692](https://our.internmc.facebook.com/intern/diff/D39860692) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Sep 29, 2022
ghstack-source-id: a474d582b9361fe04bb413b56c345ad7b3f4849c Pull Request resolved: #793
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
traverse_dpsinstead oftraverse#793This should be merged only after pytorch/pytorch#85667 has been merged into nightly and internal.
Differential Revision: D39860692