Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve note on shuffling behavior in tutorial #688

Closed
wants to merge 1 commit into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Jul 25, 2022

Stack from ghstack:

Fixes #668

Let me know if the added note is unclear and we can improve upon it.

Differential Revision: D38129786

NivekT added a commit that referenced this pull request Jul 25, 2022
ghstack-source-id: a13e06c3054a81b1c43fc3c5054c7e643616a6f9
Pull Request resolved: #688
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2022
@NivekT NivekT requested a review from ejguan July 25, 2022 20:59
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@NivekT
Copy link
Contributor Author

NivekT commented Jul 25, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/81/head branch July 29, 2022 14:20
ejguan pushed a commit to ejguan/data that referenced this pull request Aug 5, 2022
Summary:
Pull Request resolved: pytorch#688

Fixes pytorch#668

Let me know if the added note is unclear and we can improve upon it.

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D38129786

Pulled By: NivekT

fbshipit-source-id: 90ebd43ec448394146bb9136db58d07f0ae74aa4
ejguan pushed a commit that referenced this pull request Aug 5, 2022
Summary:
Pull Request resolved: #688

Fixes #668

Let me know if the added note is unclear and we can improve upon it.

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D38129786

Pulled By: NivekT

fbshipit-source-id: 90ebd43ec448394146bb9136db58d07f0ae74aa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants