[DataPipe] Automatically close parent streams and discarded streams #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
VitalyFedyunin
added a commit
that referenced
this pull request
Jun 29, 2022
ghstack-source-id: 88237d7a9aa2f2e473bbfbe7311fdec6e067f0a9 Pull Request resolved: #560
facebook-github-bot
added
the
CLA Signed
…d streams" [ghstack-poisoned]
VitalyFedyunin
added a commit
that referenced
this pull request
Jun 30, 2022
ghstack-source-id: b0a21facf64c47650e43048e59f2d482ced0228d Pull Request resolved: #560
|
Domain tests are broken because of out-of-sync torch |
NivekT
approved these changes
Jun 30, 2022
| @@ -107,7 +107,9 @@ def __iter__(self) -> Iterator[Tuple[str, io.BufferedIOBase]]: | |||
| inner_path = os.path.join(path, info.filename) | |||
| file_obj = rar.open(info) | |||
|
|
|||
| yield inner_path, StreamWrapper(file_obj) # type: ignore[misc] | |||
| yield inner_path, StreamWrapper(file_obj, stream) # type: ignore[misc] | |||
There was a problem hiding this comment.
nit: Should we pass in the name here to StreamWrapper? Or there is a good reason to leave it out?
There was a problem hiding this comment.
There is no reason to skip names, they are convenient for debugging. Will add in both cases.
| @@ -56,10 +56,13 @@ def __iter__(self) -> Iterator[Tuple[str, BufferedIOBase]]: | |||
| try: | |||
| extracted_fobj = lzma.open(data_stream, mode="rb") # type: ignore[call-overload] | |||
| new_pathname = pathname.rstrip(".xz") | |||
| yield new_pathname, StreamWrapper(extracted_fobj) # type: ignore[misc] | |||
| yield new_pathname, StreamWrapper(extracted_fobj, data_stream) # type: ignore[misc] | |||
There was a problem hiding this comment.
nit: Pass in name to StreamWrapper?
…d streams" [ghstack-poisoned]
VitalyFedyunin
added a commit
that referenced
this pull request
Jun 30, 2022
ghstack-source-id: 60a7f917991aa545487a88bbf6c147b6faff50e0 Pull Request resolved: #560
ejguan
approved these changes
Jun 30, 2022
Comment on lines
114
to
120
| for remaining in ref_it: | ||
| janitor(remaining) | ||
|
|
||
| # TODO(VItalyFedyunin): This should be Exception or warn when debug mode is enabled | ||
| if len(self.buffer) > 0: | ||
| for k, v in self.buffer.items(): | ||
| janitor(v) |
There was a problem hiding this comment.
We should put it into try-finally since we might raise ValueError in the middle of iteration.
…d streams" [ghstack-poisoned]
VitalyFedyunin
added a commit
that referenced
this pull request
Jul 5, 2022
ghstack-source-id: b796cfbf986dd01362a0d84b18915725428f0fa5 Pull Request resolved: #560
|
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D37625298