-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows wheel build #1346
Fix windows wheel build #1346
Conversation
@@ -12,7 +12,7 @@ permissions: | |||
jobs: | |||
build_test_upload: | |||
if: | | |||
github.repository == 'pytorch/data' && github.ref_name == 'main' | |||
(github.repository == 'pytorch/data' && github.ref_name == 'main') || github.event_name == 'workflow_dispatch' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this flag to allow manual workflow_dispatches to run on feature branches, to make testing easier. Going to leave this in as it seems useful in general
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1346
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 330a52e with merge base 1ad9c75 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Merging, stateful dataloader tests don't depend on this at all |
Current windows wheel build is failing on Nightly because it's trying to build S3 binaries, but we don't have any native extensions anymore. This leaves most of the code intact but just disables the envvar.
Example failing nightly:
https://github.com/pytorch/data/actions/runs/11438773492
Example passing job build step (upload fails because of branch protection, but that's fine)
https://github.com/pytorch/data/actions/runs/11444540802/job/31839644282