Fix windows wheel build #1346
Merged
Fix windows wheel build #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
andrewkho
had a problem deploying
to
pytorchbot-env
GitHub Actions
Failure
andrewkho
commented
Oct 21, 2024
| @@ -12,7 +12,7 @@ permissions: | |||
| jobs: | |||
| build_test_upload: | |||
| if: | | |||
| github.repository == 'pytorch/data' && github.ref_name == 'main' | |||
| (github.repository == 'pytorch/data' && github.ref_name == 'main') || github.event_name == 'workflow_dispatch' | |||
There was a problem hiding this comment.
Adding this flag to allow manual workflow_dispatches to run on feature branches, to make testing easier. Going to leave this in as it seems useful in general
ramanishsingh
approved these changes
Oct 21, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1346
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 330a52e with merge base 1ad9c75 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Merging, stateful dataloader tests don't depend on this at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current windows wheel build is failing on Nightly because it's trying to build S3 binaries, but we don't have any native extensions anymore. This leaves most of the code intact but just disables the envvar.
Example failing nightly:
https://github.com/pytorch/data/actions/runs/11438773492
Example passing job build step (upload fails because of branch protection, but that's fine)
https://github.com/pytorch/data/actions/runs/11444540802/job/31839644282