[DataPipe] Ensures Prefetcher shuts down properly #1166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 17, 2023
ghstack-source-id: e4ed1282793ee9f9491761275ff6c67c22bc3039 Pull Request resolved: #1166
facebook-github-bot
added
the
CLA Signed
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ejguan Doesn't seem like it is strictly necessary (?) but it is a good safeguard |
ejguan
approved these changes
May 17, 2023
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 17, 2023
ghstack-source-id: be52b2f2999a2942c596cf9242c2eae8950e9c24 Pull Request resolved: #1166
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 18, 2023
ghstack-source-id: 12ccf97a9b1c4a922020653b9be74d54a763f0d1 Pull Request resolved: #1166
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 18, 2023
ghstack-source-id: ad503d7719137f964c705978574cbc78cd7e5598 Pull Request resolved: #1166
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 19, 2023
ghstack-source-id: dd778b5c86cc13a8b084c86385cc10bd163659d2 Pull Request resolved: #1166
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 19, 2023
ghstack-source-id: 916c68e42219e852212e4b54b0b7b1f1365a5f08 Pull Request resolved: #1166
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 19, 2023
ghstack-source-id: 0fb262b3ac3ed596db1f08161d7adb5bdc20e04f Pull Request resolved: #1166
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 19, 2023
ghstack-source-id: b1b79614345ba2e0a432269c026661249d9c2ba5 Pull Request resolved: #1166
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
approved these changes
May 22, 2023
Differential Revision: [D45967152](https://our.internmc.facebook.com/intern/diff/D45967152) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
May 23, 2023
ghstack-source-id: cb24f3c6ad0c01c7fbe7bf31ad532db9a0bae27e Pull Request resolved: #1166
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D45967152