Fix pin_memory_fn for NamedTuple #1086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
pushed a commit
that referenced
this pull request
Apr 19, 2023
Summary: Fixes #1085 Per title. And, even though I can add a test, this test won't be executed as we don't have a GPU CI machine yet. I have tested on my local machine though Pull Request resolved: #1086 Reviewed By: NivekT Differential Revision: D44094225 Pulled By: ejguan fbshipit-source-id: 9c8414c31b76c93cee7e31c4e2da14076e9792bf
ejguan
added a commit
that referenced
this pull request
Apr 20, 2023
Summary: Fixes #1085 Per title. And, even though I can add a test, this test won't be executed as we don't have a GPU CI machine yet. I have tested on my local machine though Pull Request resolved: #1086 Reviewed By: NivekT Differential Revision: D44094225 Pulled By: ejguan fbshipit-source-id: 9c8414c31b76c93cee7e31c4e2da14076e9792bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1085
Per title. And, even though I can add a test, this test won't be executed as we don't have a GPU CI machine yet.
I have tested on my local machine though