-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables in Documentation not rendering properly #959
Comments
The last commit from 0.5.1 is 222877d |
Also the section expansion works less well now, but unsure if it is related. Some suspects:
|
Summary: Fixes #689 #959 #922 ### Changes - Add a section regarding determinism for ReadingService - Add simple tutorial for DataLoader2 - Fix table rendering for dataloader.html Example result can be found: https://ejguan.github.io/dataloader2.html Pull Request resolved: #980 Reviewed By: NivekT Differential Revision: D42903523 Pulled By: ejguan fbshipit-source-id: 3d5093312953ac5fb5f247b6a65e161b4842bf8f
It's weird that the table is still not rendered correctly. |
Yea... I think my local copy is rendered properly as well. Unsure what's specific about GHA process that causes this. |
Let me try to update my sphinx to 6.1.3 aligned with release workflow to see if my local build would change or not. |
After updated |
Aha, simple solution -> pin sphinx to 5 lke pytorch https://github.com/pytorch/pytorch/blob/207399cf5f68a6370cbacc28fce3fc5d9132c87f/docs/requirements.txt#LL1 |
Confirm the patch works. |
📚 The doc issue
Compared to the last release, the tables in the documentation of the
main
branch is rendering differently. I do not recall any intentional changes to the format of our documentation or generation. We should have a look at this before the next release.Before (0.5.1):
Current (main):
The text was updated successfully, but these errors were encountered: