Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataLoader2 does not properly reset iterator when using PrototypeMultiprocessingReadingService and prefetch #825

Closed
NivekT opened this issue Oct 12, 2022 · 1 comment
Closed

DataLoader2 does not properly reset iterator when using PrototypeMultiprocessingReadingService and prefetch #825

NivekT opened this issue Oct 12, 2022 · 1 comment

Comments

@NivekT
Copy link
Contributor

NivekT commented Oct 12, 2022

🐛 Describe the bug

Vision team reported this behavior on Linux

dp = ...  # something with prefetch
dl = DataLoader2(reading_service=PrototypeMultiProcessingReadingService())
for _ in dl:
    # this works fine

for _ in dl:
    # dl is empty now, this never gets hit!

Versions

#815

cc: @VitalyFedyunin
@NivekT NivekT mentioned this issue Oct 12, 2022
Closed
VitalyFedyunin added a commit that referenced this issue Oct 18, 2022
@VitalyFedyunin
Update base for Update on "Adding Prefetcher into the PrototypeRS and…
d18c457 
… fixing prefetcher bug"

Fixes: #815 


Fixes #825

Differential Revision: [D40308358](https://our.internmc.facebook.com/intern/diff/D40308358)

[ghstack-poisoned]
VitalyFedyunin added a commit that referenced this issue Oct 18, 2022
@VitalyFedyunin
Update on "Adding Prefetcher into the PrototypeRS and fixing prefetch…
029315a 
…er bug"

Fixes: #815 


Fixes #825

Differential Revision: [D40308358](https://our.internmc.facebook.com/intern/diff/D40308358)

[ghstack-poisoned]
@ejguan
Copy link
Contributor

ejguan commented Dec 5, 2022

Closing as #826 has been landed

@ejguan ejguan closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NivekT @ejguan