Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SingleProcessReadingService for DataLoader2 by default #720

Closed
ejguan opened this issue Aug 5, 2022 · 0 comments
Closed

Add SingleProcessReadingService for DataLoader2 by default #720

ejguan opened this issue Aug 5, 2022 · 0 comments

Comments

@ejguan
Copy link
Contributor

ejguan commented Aug 5, 2022

🚀 The feature

Add SingleProcessReadingService to adapt the graph for the sake of:

  • Shuffle seed setting per epoch
  • Set shuffle/sharding
  • etc.

Pros:
This would prevent making DataLoader2 more complicated. The reading service should take charge of all adaptation of the graph of DataPipes.

Cons:
By adding SingleProcessReadingService, we need mixed ReadingServices for the most of cases.

Motivation, pitch

To align the behavior of DataLoader2 with or without MPRS.

Alternatives

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement InProcessReadingService ejguan/data
1 participant
@ejguan