Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataloader2 does not invoke set_seed if used without ReadingService #1107

Closed
sehoffmann opened this issue Mar 23, 2023 · 1 comment
Closed

Dataloader2 does not invoke set_seed if used without ReadingService #1107

sehoffmann opened this issue Mar 23, 2023 · 1 comment

Comments

@sehoffmann
Copy link

sehoffmann commented Mar 23, 2023 •
edited
Loading

🐛 Describe the bug

See title: My custom datapipe with set_seed does not get invoked when using Dataloader2 (and calling seed(123)). This makes it impossible to fixate seeds when one does not want to use multiprocessing.

This is due to https://github.com/pytorch/data/blob/main/torchdata/dataloader2/dataloader2.py#L210

Versions

e78ab6c
@NivekT
Copy link
Contributor

NivekT commented Mar 23, 2023

I think this is a good call out. The plan is to have SingleProcessReadingService and use that as default.

See #720

@ejguan ejguan mentioned this issue Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement InProcessReadingService ejguan/data
2 participants
@sehoffmann @NivekT