Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling windows update #846

Merged
merged 3 commits into from
Sep 9, 2021
Merged

improve handling windows update #846

merged 3 commits into from
Sep 9, 2021

Conversation

mszhanyi
Copy link
Contributor

@mszhanyi mszhanyi commented Sep 8, 2021

fix pytorch/pytorch#64536

  1. Add sc stop wuauserv as well
  2. Restore windows update after cuda installation.
  3. Improve readability of the log output.

testing PR pytorch/pytorch#63551

@mszhanyi
Copy link
Contributor Author

mszhanyi commented Sep 9, 2021

@malfet
Copy link
Contributor

malfet commented Sep 9, 2021

@mszhanyi please do not re-enable wsupdate( as it's likely slow down test), otherwise looks good to me.

@mszhanyi
Copy link
Contributor Author

mszhanyi commented Sep 9, 2021

@mszhanyi please do not re-enable wsupdate( as it's likely slow down test), otherwise looks good to me.

@malfet Could we re-enable them for some time?
I'm a little afraid that the reason why circleci machines start wsupdate frequently AGAIN in this week is that we have disabled the wsupdate for a long time. So disabling the service become invalid. From Aug20 to Aug27, there isn't any errors caused by the wsupdate. Maybe we need to give these machine an chance to update.

I think what we might to do is to ensure no wsupdate when installing cuda.

@seemethere
Copy link
Member

@mszhanyi please do not re-enable wsupdate( as it's likely slow down test), otherwise looks good to me.

@malfet Could we re-enable them for some time?
I'm a little afraid that the reason why circleci machines start wsupdate frequently AGAIN in this week is that we have disabled the wsupdate for a long time. So disabling the service become invalid. From Aug20 to Aug27, there isn't any errors caused by the wsupdate. Maybe we need to give these machine an chance to update.

I think what we might to do is to ensure no wsupdate when installing cuda.

We shouldn't be afraid of this, the CircleCI machines shouldn't be long lived so we shouldn't worry about turning updates off on them

@malfet malfet merged commit 0c7f003 into pytorch:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random Cuda Installation failed in Windows Nightly CI
4 participants