-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move 2 binaries to S3 #841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment. https://github.com/pytorch/vision/pull/4058/files#r701067987
@peterjc123 , that's a different issue. Time is a little long, I don't remember very clearly why the snapshot is in that place. |
I think PR title is a bit misleading: It does not move 2 binaries, it moves one and then deletes another. Alternatively, split this PR in two: one that replaces one URL with another (which is pretty straightforward and requires no testing) and another that deletes those extra dlls download/installation |
@malfet , Thank your reminder. there's a test PR pytorch/pytorch#63551 for it. I planned to add the verification link when all tests passed. At first, I planned to moved 2 binaries to S3, which the commit 3a10296 did. But vision has skipped all cuda tests in their CI now, so it's a little hard to me to reverify it. |
Fix #788