manywheel: Refactor docker build / upload scripts #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does a big refactor on the docker build / upload scripts to make them more accessible similar to the build / upload process for conda and libtorch This also updates the README.md for manywheel/README.md Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
manywheel_docker_refactor
branch
from
a28e713 to
5a4956f
Compare
malfet
approved these changes
Apr 28, 2021
janeyx99
approved these changes
Apr 28, 2021
Co-authored-by: Jane (Yuan) Xu <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a big refactor on the docker build / upload scripts to make them
more accessible similar to the build / upload process for conda and
libtorch
This also updates the README.md for manywheel/README.md
Enables #720 to be built easier
Copied from the README.md:
Building docker images
To build all docker images you can use the convenience script:
To build a specific docker image use:
Signed-off-by: Eli Uriegas [email protected]