Logic for nightly builds with ONNX tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benefit of doing it this way is that some more environment variables, e.g., CONDA_PREFIX, get set. It will turn out that this is important to get the onnx build to find protobuf. Signed-off-by: Edward Z. Yang <[email protected]>
If jenkins_nightly is set, we install some extra software from onnx-pytorch and run some extra tests to see if ONNX works. Signed-off-by: Edward Z. Yang <[email protected]>
peterjc123
referenced
this pull request
in peterjc123/builder
Apr 28, 2019
# This is the 1st commit message: # This is a combination of 16 commits. # This is the 1st commit message: . # This is the commit message #2: Enable wheel tests # This is the commit message #3: Remove useless % # This is the commit message #4: Debug CPU conda # This is the commit message #5: . # This is the commit message #6: . # This is the commit message #7: Revert debugging stuff # This is the commit message #8: . # This is the commit message #9: Revert to normal # This is the commit message #10: Revert to legacy version # This is the commit message #11: Disable all except CPU conda # This is the commit message #12: Explicit python version # This is the commit message #13: Revert "Explicit python version" This reverts commit a45b285. # This is the commit message #14: Revert "Disable all except CPU conda" This reverts commit 2c69de7. # This is the commit message #15: Use branches first # This is the commit message #16: Use hash # This is the commit message #2: . # This is the commit message #3: .
soumith
pushed a commit
that referenced
this pull request
Apr 28, 2019
# This is the 1st commit message: # This is a combination of 16 commits. # This is the 1st commit message: . # This is the commit message #2: Enable wheel tests # This is the commit message #3: Remove useless % # This is the commit message #4: Debug CPU conda # This is the commit message #5: . # This is the commit message #6: . # This is the commit message #7: Revert debugging stuff # This is the commit message #8: . # This is the commit message #9: Revert to normal # This is the commit message #10: Revert to legacy version # This is the commit message #11: Disable all except CPU conda # This is the commit message #12: Explicit python version # This is the commit message #13: Revert "Explicit python version" This reverts commit a45b285. # This is the commit message #14: Revert "Disable all except CPU conda" This reverts commit 2c69de7. # This is the commit message #15: Use branches first # This is the commit message #16: Use hash # This is the commit message #2: . # This is the commit message #3: .
jithunnair-amd
pushed a commit
to jithunnair-amd/builder
that referenced
this pull request
Oct 31, 2022
* Update to so patching for ROCm
Wildcard used in grep to grab the actual numbered so file referenced
in patchelf. This allows the removal of specifying the so number in
DEPS_LIST & DEPS_SONAME
This commit also adds the functionality for trimming so names to
build_libtorch.sh from build_common.sh
* Refactor to remove switch statement in build_rocm.sh
This commit refactors build_rocm.sh and brings in a few major updates:
- No longer required to specify the full .so name (with number) for ROCm libraries
- The .so versions are copied and the patching code will fix the links to point to this version
- No longer required to specify paths for ROCm libraries allowing the removal of the large switch
- Paths are acquired programmatically with find
- No longer required to specify both the path and filename for the OS specific libraries
- Programatically extract file name from the path
- Automatically extract Tensile/Kernels files for the architectures specified in PYTORCH_ROCM_ARCH
and any non-arch specific files e.g. TensileLibrary.dat
jithunnair-amd
pushed a commit
to jithunnair-amd/builder
that referenced
this pull request
Dec 14, 2022
* Update to so patching for ROCm
Wildcard used in grep to grab the actual numbered so file referenced
in patchelf. This allows the removal of specifying the so number in
DEPS_LIST & DEPS_SONAME
This commit also adds the functionality for trimming so names to
build_libtorch.sh from build_common.sh
* Refactor to remove switch statement in build_rocm.sh
This commit refactors build_rocm.sh and brings in a few major updates:
- No longer required to specify the full .so name (with number) for ROCm libraries
- The .so versions are copied and the patching code will fix the links to point to this version
- No longer required to specify paths for ROCm libraries allowing the removal of the large switch
- Paths are acquired programmatically with find
- No longer required to specify both the path and filename for the OS specific libraries
- Programatically extract file name from the path
- Automatically extract Tensile/Kernels files for the architectures specified in PYTORCH_ROCM_ARCH
and any non-arch specific files e.g. TensileLibrary.dat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages