Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Arm64 scripts #2044

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

iremyux
Copy link

@iremyux iremyux commented Nov 25, 2024

This PR adds the scripts necessary for a successful Windows Arm64 build.
The nightly Windows Arm64 workflows using the scripts of this PR can be found on this draft PR to pytorch/pytorch : pytorch/pytorch#139760

@atalman
Copy link
Contributor

atalman commented Dec 2, 2024

Hi @iremyux could you please add Workflow and move the PR to pytorch/pytorch ? Please use this runner: windows-11-arm64 . Thank you.

@iremyux
Copy link
Author

iremyux commented Dec 2, 2024

Hi @iremyux could you please add Workflow and move the PR to pytorch/pytorch ? Please use this runner: windows-11-arm64 . Thank you.

Hey @atalman we actually have the draft PR to pytorch/pytorch ready. I've been using the windows-11-arm64 runners already. Here is the link : pytorch/pytorch#139760
But we're using the scripts on this fork, shouldn't this one to pytorch/builder get merged first?

@atalman
Copy link
Contributor

atalman commented Dec 2, 2024

hi @iremyux This is great! Thank you. Please move these scripts to the pytorch/pytorch PR. This is where linux aarch64 scripts live : https://github.com/pytorch/pytorch/tree/main/.ci/aarch64_linux

We are trying to get rid of builder project altogeather

@iremyux
Copy link
Author

iremyux commented Dec 2, 2024

@atalman I see, I was not aware of that. The other platforms are still using builder, hence this PR. I'll prepare the new one & will ask for a review afterwards. Thanks for the quick reply. Should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants