Enable linting via ruff #1551
Closed
Enable linting via ruff #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Well, this was done in #1557 (duplicate work could've probably been avoided if someone had taken a look at open PRs back then). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was an utterly unused flake8 configuration in this repo (apparently gotten orphaned in e97f8cc) and there had been some issues a linter could have possibly caught in #1433 (see dc0a579).
This gets rid of the abandoned flake8 configuration in favor of ruff and wires it up to be runnable via pre-commit and automagically in GitHub Actions.
It also applies the
ruff --fixautofixes in the third commit.I'd recommend enabling more (and stricter) Ruff rules in the future, this only has a very bare skeleton set.