Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aarch64] Install libjpeg when building Torchvision #1363

Merged
merged 3 commits into from
Mar 21, 2023
Merged

[aarch64] Install libjpeg when building Torchvision #1363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddaa33d
Fix torchvision image extension compilation
atalman Mar 21, 2023
b3dfc27
Fix torchvision image extension compilation
atalman Mar 21, 2023
47a08d4
Set enable_mkldnn to pypi build
atalman Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion aarch64_linux/build_aarch64_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,11 @@ def build_torchvision(host: RemoteHost, *,
"v2.0.0": ("0.15.1", "rc2"),
})
print('Building TorchVision wheel')

# Please note libnpg and jpeg are required to build image.so extension
if(use_conda):
host.run_cmd("conda install -y libpng jpeg")

build_vars = ""
if branch == 'nightly':
version = host.check_output(["if [ -f vision/version.txt ]; then cat vision/version.txt; fi"]).strip()
Expand Down Expand Up @@ -768,7 +773,7 @@ def parse_arguments():
configure_system(host,
compiler=args.compiler,
python_version=python_version,
enable_mkldnn=False)
enable_mkldnn=not args.disable_mkldnn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, as torch is not built, but installed from PyPI, i.e. feel free to just omit it

Suggested change
enable_mkldnn=not args.disable_mkldnn)
)

print("Installing PyTorch wheel")
host.run_cmd("pip3 install torch")
build_domains(host,
Expand Down