Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence some warnings in unit tests #2628

Closed
wants to merge 3 commits into from

Conversation

saitcakmak
Copy link
Contributor

Summary: Silences warnings for non-log EI acqfs and deprecated model converter code.This will reduce the noise in test outputs.

Differential Revision: D66004225

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66004225

Summary:

This was deprecated and marked for removal in v0.11.

Reviewed By: esantorella

Differential Revision: D66003588
Summary:

Legacy non-linear inequality constraint format has been deprecated since pytorch#1793.

Reviewed By: esantorella

Differential Revision: D66003879
Summary:

Silences warnings for non-log EI acqfs and deprecated model converter code.This will reduce the noise in test outputs.

Reviewed By: esantorella

Differential Revision: D66004225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66004225

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (92d73e4) to head (b374ea2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2628      +/-   ##
==========================================
- Coverage   99.98%   99.98%   -0.01%     
==========================================
  Files         196      196              
  Lines       17332    17313      -19     
==========================================
- Hits        17330    17311      -19     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Nov 15, 2024
Summary:

Silences warnings for non-log EI acqfs and deprecated model converter code.This will reduce the noise in test outputs.

Reviewed By: esantorella

Differential Revision: D66004225
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9c7521f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants