Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HeteroskedasticSingleTaskGP #2616

Closed
wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary:
This model has been buggy for quite a long time and we still haven't fixed it. Removing it should be preferable to keeping around a known buggy model. Example bug reports:

Differential Revision: D65543676

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65543676

saitcakmak added a commit to saitcakmak/Ax that referenced this pull request Nov 6, 2024
Summary:
X-link: pytorch/botorch#2616

This model has been buggy for quite a long time and we still haven't fixed it. Removing it should be preferable to keeping around a known buggy model. Example bug reports:
- pytorch/botorch#861
- pytorch/botorch#933
- pytorch/botorch#2551

Differential Revision: D65543676
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (cd657d9) to head (232aae1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2616      +/-   ##
==========================================
- Coverage   99.98%   99.98%   -0.01%     
==========================================
  Files         196      196              
  Lines       17368    17328      -40     
==========================================
- Hits        17366    17326      -40     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Nov 6, 2024
Summary:

This model has been buggy for quite a long time and we still haven't fixed it. Removing it should be preferable to keeping around a known buggy model. Example bug reports:
- pytorch#861
- pytorch#933
- pytorch#2551

Differential Revision: D65543676
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65543676

@saitcakmak saitcakmak changed the title Remove HeterogeneousSingleTaskGP Remove HeteroskedasticSingleTaskGP Nov 6, 2024
Summary:

This model has been buggy for quite a long time and we still haven't fixed it. Removing it should be preferable to keeping around a known buggy model. Example bug reports:
- pytorch#861
- pytorch#933
- pytorch#2551

Reviewed By: esantorella

Differential Revision: D65543676
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65543676

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 60387d0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants