Clean up settings.debug #2612
Closed
Clean up settings.debug #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65498337 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 99.98% 99.98% -0.01%
==========================================
Files 196 196
Lines 17372 17359 -13
==========================================
- Hits 17370 17357 -13
Misses 2 2 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Nov 5, 2024
Summary: In the past, `settings.debug` used to supress all `BoTorchWarnings`. Some time ago, we reduced its scope and started surfacing these warnings again. Since then, there are only a couple places where `settings.debug` is used. I was curious how much usage it had left and decided to clean it up completely while at it. Differential Revision: D65498337
saitcakmak
force-pushed
the
export-D65498337
branch
from
3692626
to
30c0fe0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65498337 |
Summary: In the past, `settings.debug` used to supress all `BoTorchWarnings`. Some time ago, we reduced its scope and started surfacing these warnings again. Since then, there are only a couple places where `settings.debug` is used. I was curious how much usage it had left and decided to clean it up completely while at it. Differential Revision: D65498337
saitcakmak
force-pushed
the
export-D65498337
branch
from
30c0fe0
to
c0801bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65498337 |
|
This pull request has been merged in 8b13120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In the past,
settings.debugused to supress allBoTorchWarnings. Some time ago, we reduced its scope and started surfacing these warnings again. Since then, there are only a couple places wheresettings.debugis used. I was curious how much usage it had left and decided to clean it up completely while at it.Differential Revision: D65498337