Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Userbenchmark] Allow to continue on error when installing test_bench #2550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Userbenchmark] Allow to continue on error when installing test_bench #2550

wants to merge 1 commit into from

Conversation

shink
Copy link
Contributor

@shink shink commented Nov 29, 2024 •
edited
Loading

test_bench has many models, and sometimes we want to skip failed installations when installing them.

Usage

python install.py --userbenchmark test_bench --continue_on_fail

Result

$ python install.py --userbenchmark test_bench BERT_pytorch hf_GPT2 --skip hf_GPT2 --continue_on_fail
checking packages numpy, torch are installed, generating constaints...OK
Installing userbenchmark test_bench with extra args: []
Installing BERT_pytorch...OK

@shink
Copy link
Contributor Author

shink commented Nov 29, 2024

Hey @FindHao does this change make sense? Could you please help review? Thanks so much!

@shink shink force-pushed the feat/test_bench/continue_on_error branch from 3ea0f9b to b2673cc Compare December 2, 2024 06:27
FindHao
FindHao approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding it!

@facebook-github-bot
Copy link
Contributor

@FindHao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FindHao FindHao FindHao approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shink @facebook-github-bot @FindHao