[CI] Run unit test with non-editable installation #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
tweak-unittest-job
branch
from
44abacd to
25cca95
Compare
mthrok
force-pushed
the
tweak-unittest-job
branch
10 times, most recently
from
05160c5 to
91dd92b
Compare
mthrok
force-pushed
the
tweak-unittest-job
branch
from
91dd92b to
30aa240
Compare
vincentqb
reviewed
Aug 4, 2020
| @@ -6,5 +6,5 @@ eval "$(./conda/Scripts/conda.exe 'shell.bash' 'hook')" | |||
| conda activate ./env | |||
|
|
|||
| python -m torch.utils.collect_env | |||
| pytest --cov=torchaudio --junitxml=test-results/junit.xml -v --durations 20 test | |||
| flake8 torchaudio test | |||
There was a problem hiding this comment.
flake8 is now tested separately, hence why this is removed here, right?
vincentqb
reviewed
Aug 4, 2020
| fi | ||
| cd test | ||
| pytest "${args[@]}" "${common_args[@]}" torchaudio_unittest |
There was a problem hiding this comment.
could the following command work without moving files from test/ to test/torchaudio_unittest/?
pytest "${args[@]}" "${common_args[@]}" test
There was a problem hiding this comment.
An alternative would be remove source torchaudio directory.
- do
rm torchaudiobefore running test - ugly - Move the source code to
src. See this. - though this is clean and standard way, it involves the reorg of whole source code.
There was a problem hiding this comment.
Nice, thanks for pointing these out! I'm ok with the approach suggested here -- though neither pytorch nor the other libraries do it.
vincentqb
reviewed
Aug 4, 2020
|
Thanks |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Update 'Was this Helpful?' tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been running unit test with editable installation. (i.e.
python setup.py develop), with which we missed issues like #842.This PR makes installation in CI non-editable, and change test directory structure so that the source code will not shadow the installed version of
torchaudio. With simplepytest test,pytestmodifies and prepend checked out repository, which shadows the installed version.To remedy this, the whole test suites has been moved from
./testto./test/torchaudio_unittest. This adds nice module structure to our test code and we can do absolute import in each test module, which makes it possible again to run test withpython -m unittest torchaudio_unittest/XXX.pyThis change does not affect the regular development process (
python setup.py develop&&pytest test)