Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GTZAN dataset sorted and use on-the-fly data in GTZAN test #819

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jul 23, 2020

  1. Change GTZAN to return samples in order sorted by file paths.
  2. Change test to use on-the-fly data.

Relates to #764 and #791

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #819 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   89.87%   90.06%   +0.18%     
==========================================
  Files          35       35              
  Lines        2716     2717       +1     
==========================================
+ Hits         2441     2447       +6     
+ Misses        275      270       -5     
Impacted Files Coverage Δ
torchaudio/datasets/gtzan.py 88.05% <100.00%> (+7.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdcd7b...62d15f1. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review July 23, 2020 18:12
@mthrok mthrok requested a review from vincentqb July 23, 2020 18:12
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd say the long term solution is to align GTZAN's implementation with the other ones also, and fix all at the same time.

@mthrok mthrok merged commit 68f6a6a into pytorch:master Jul 23, 2020
@mthrok
Copy link
Collaborator Author

mthrok commented Jul 23, 2020

thanks!

@mthrok
Copy link
Collaborator Author

mthrok commented Jul 23, 2020

LGTM, but I'd say the long term solution is to align GTZAN's implementation with the other ones also, and fix all at the same time.

Agreed. We need to find a generic way to perform pattern matching on paths regardless of platform.

@mthrok mthrok mentioned this pull request Jul 23, 2020
6 tasks
@mthrok mthrok deleted the fix-gtzan-order branch July 23, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants