Run unit test on CCI #576
Merged
Run unit test on CCI #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
test-cci
branch
2 times, most recently
from
91e69f9 to
ffff728
Compare
|
I'm currently in the process of setting up the same for torchtext pytorch/text#740 - Let's chat about this if you want or I'll just wait for you to finish the work and then go from there since torchtext needs the same work done. |
Sounds good. This PR is mostly finished and ready for review, so we can chat about it. 🙂 |
seemethere
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit test on Circle CI.
These tests are added as a new workflow so that binary build and unit tests are independent each other.