-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dlopen for FFmpeg #3353
Use dlopen for FFmpeg #3353
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3353
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit b7f3547: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base c7ac1af:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
508f735
to
8248236
Compare
35ed61f
to
0f69178
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This commit changes the way FFmpeg extension is built and used. Instead of linking (LGPL) FFmpeg libraries to torchaudio at build time, It uses dlopen to search and link them at run time. For dlopen-ing, we use PyTorch's `at::DynamicLibrary` class, which provides portable wrapper. Pull Request resolved: pytorch#3353 Differential Revision: D46059199 Pulled By: mthrok fbshipit-source-id: 6ae94cd3f3ded717d0e0956e9d214e1df5c1185f
This pull request was exported from Phabricator. Differential Revision: D46059199 |
Summary: This commit changes the way FFmpeg extension is built and used. Instead of linking (LGPL) FFmpeg libraries to torchaudio at build time, It uses dlopen to search and link them at run time. For dlopen-ing, we use PyTorch's `at::DynamicLibrary` class, which provides portable wrapper. Pull Request resolved: pytorch#3353 Differential Revision: D46059199 Pulled By: mthrok fbshipit-source-id: 8acf2b572a524278aa8d839828740d082a40b434
This pull request was exported from Phabricator. Differential Revision: D46059199 |
Summary: This commit changes the way FFmpeg extension is built and used. Instead of linking (LGPL) FFmpeg libraries to torchaudio at build time, It uses dlopen to search and link them at run time. For dlopen-ing, we use PyTorch's `at::DynamicLibrary` class, which provides portable wrapper. Pull Request resolved: pytorch#3353 Differential Revision: D46059199 Pulled By: mthrok fbshipit-source-id: e030fdec7ee2dc99c2d1c29d56c1e66e2ca42ccc
This pull request was exported from Phabricator. Differential Revision: D46059199 |
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
This pull request has been reverted by ab7a39f. |
Summary: This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: f39c9c639e9da1cbdd61c31008014b2b0b91af67
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: 097a4cc6ba7a0fbae317632ee81e4aa895f62fde
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: 10a193c7fa27f6075975609974890c9ab80ddc6b
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: 2e3f36de6962ebceb05dccf6f7763826c25960aa
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: 4b675e1c1239503f087a0fd50d078340c09d2282
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: 5cbf733b40e4499570336804af597c3d281321ba
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: 08975d1973a1f8c2c402c5e76fe0cbf469fa9156
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Differential Revision: D46403783 fbshipit-source-id: 5b28c0b136552b2f5c70ee487ae7840efda4e18a
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Please refer to stub.h for more technical detail. Differential Revision: D46403783 fbshipit-source-id: 28758ed3b40e4de418c9f7014bd29e35cefbe3ec
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Please refer to stub.h for more technical detail. Differential Revision: D46403783 fbshipit-source-id: 3578de808d6c87358226ee5372365c71cc62d6d7
Summary: Pull Request resolved: pytorch#3402 This is a second attempt of pytorch#3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Please refer to stub.h for more technical detail. Differential Revision: D46403783 fbshipit-source-id: 8481ca9d465d46b08db8c24d86b471142054d5c6
Summary: Pull Request resolved: #3402 This is a second attempt of #3353. The basic logic to enable dlopen for FFmpeg libraries are same. It uses `at::DynamicLibrary`, which allows to compile torchaudio without linking FFmpeg libraries. This time, the option to enable this feature DLOPEN_FFMPEG has been added, so that users have a way to disable this feature and keep using build-time linking. Please refer to stub.h for more technical detail. Differential Revision: D46403783 fbshipit-source-id: ca3db57ff6bdc50c8c225d22f12f3e76c6dc3f16
This commit changes the way FFmpeg extension is built and used.
Instead of linking (LGPL) FFmpeg libraries to torchaudio at build time,
It uses dlopen to search and link them at run time.
For dlopen-ing, we use PyTorch's
at::DynamicLibrary
class, which providesportable wrapper.