[BC-Breaking] Drop pseudo complex support from phase_vocoder / TimeStretch #1957
Conversation
mthrok
changed the title
mthrok
force-pushed
the
remove-pseudo-complex-support-phase-vocoder
branch
from
85c56eb to
6093387
Compare
|
|
||
| if not is_complex: | ||
| complex_specgrams = torch.view_as_complex(complex_specgrams) | ||
|
|
||
| # pack batch | ||
| shape = complex_specgrams.size() |
There was a problem hiding this comment.
The complex_specgrams can be renamed as specgram since the dtype of it is always complex, but that is BC-Breaking, maybe it's fine.
There was a problem hiding this comment.
Yeah, unfortunately, it is BC-breaking and we do not have a strong reason to push the BC-breaking here.
| n_freq = 400 | ||
| hop_length = 512 | ||
| fixed_rate = 1.3 | ||
| tensor = torch.view_as_complex(torch.rand((10, 2, n_freq, 10, 2))) | ||
| tensor = torch.rand((10, 2, n_freq, 10), dtype=torch.cfloat) |
There was a problem hiding this comment.
Could you change it by using the get_spectrogram method?
There was a problem hiding this comment.
Done. Using get_specgrogram first time in a while and now I feel it's not user-friendly...
| @@ -124,17 +124,13 @@ def test_batch_lfcc(self): | |||
|
|
|||
| self.assert_batch_consistency(transform, waveform, atol=1e-4, rtol=1e-5) | |||
|
|
|||
| @parameterized.expand([(True, ), (False, )]) | |||
| def test_batch_TimeStretch(self, test_pseudo_complex): | |||
| def test_batch_TimeStretch(self): | |||
| rate = 2 | |||
| num_freq = 1025 | |||
| num_frames = 400 | |||
| batch = 3 | |||
|
|
|||
| spec = torch.randn(batch, num_freq, num_frames, dtype=torch.complex64) | |||
| self._assert_consistency_complex( | ||
| T.TimeStretch(n_freq=n_freq, hop_length=hop_length, fixed_rate=fixed_rate), | ||
| tensor, | ||
| test_pseudo_complex | ||
| False, |
There was a problem hiding this comment.
This is False by default, so we could also just remove the parameter here
There was a problem hiding this comment.
I removed the option from the helper function as it is no longer necessary.
mthrok
force-pushed
the
remove-pseudo-complex-support-phase-vocoder
branch
from
6093387 to
8d8feab
Compare
mthrok
force-pushed
the
remove-pseudo-complex-support-phase-vocoder
branch
from
8d8feab to
8cf40ef
Compare
Following the plan #1337, this PR drops the support for pseudo complex type from
F.phase_vocoderandT.TimeStretch.