Improve resampling documentation #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
commented
May 20, 2021
| @@ -770,6 +770,8 @@ def resample_waveform(waveform: Tensor, | |||
| but less efficient. We suggest around 4 to 10 for normal use. (Default: ``6``) | |||
| rolloff (float, optional): The roll-off frequency of the filter, as a fraction of the Nyquist. | |||
| Lower values reduce anti-aliasing, but also reduce some of the highest frequencies. (Default: ``0.99``) | |||
| resampling_method (str, optional): The resampling method to use. | |||
| Options: [``sinc_interpolation``, ``kaiser_window``] (Default: ``'sinc_interpolation'``) | |||
There was a problem hiding this comment.
@mthrok any thoughts on whether or not we should also add beta as a parameter to kaldi's resample waveform? this would make it more consistent with the trasnforms/functional form, but not "kaldi-compliant". resampling_method was added for easier testing which was done in compliance_kaldi_test -- if we remove beta, do we also want to remove resampling_method once we migrate the tests to functional?
mthrok
approved these changes
May 20, 2021
carolineechen
force-pushed
the
resample-docs
branch
from
5175fdf to
310cfc2
Compare
|
Let's add the possibility to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve resampling documentation
cc #1487