-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VAD docstring and check for input shape length #1513
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import math | ||
import warnings | ||
from typing import Optional | ||
|
||
import torch | ||
|
@@ -1374,7 +1375,10 @@ def vad( | |
so in order to trim from the back, the reverse effect must also be used. | ||
|
||
Args: | ||
waveform (Tensor): Tensor of audio of dimension `(..., time)` | ||
waveform (Tensor): Tensor of audio of dimension `(channels, time)` or `(time)` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: "channel", see convention |
||
Tensor of shape `(channels, time)` is treated as a multi-channel recording | ||
of the same event and the resulting output will be trimmed to the earliest | ||
voice activity in any channel. | ||
sample_rate (int): Sample rate of audio signal. | ||
trigger_level (float, optional): The measurement level used to trigger activity detection. | ||
This may need to be cahnged depending on the noise level, signal level, | ||
|
@@ -1420,6 +1424,15 @@ def vad( | |
http://sox.sourceforge.net/sox.html | ||
""" | ||
|
||
if waveform.ndim > 2: | ||
warnings.warn( | ||
"Expected input tensor dimension of 1 for single channel" | ||
f" or 2 for multi-channel. Got {waveform.ndim} instead. " | ||
"Batch semantics is not supported. " | ||
"Please refer to https://github.com/pytorch/audio/issues/1348" | ||
" and https://github.com/pytorch/audio/issues/1468." | ||
Comment on lines
+1432
to
+1433
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: two links might be confusing. the first is the most relevant one to this issue. |
||
) | ||
|
||
measure_duration: float = ( | ||
2.0 / measure_freq if measure_duration is None else measure_duration | ||
) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide the docstring which describes the condition when the warning should be issued and when not, so that any future maintainer can understand the intend easily?
I think we can merge
test_vad_warning
andtest_vad_no_warning
.