Add autograd tests for TimeMasking/FrequencyMasking #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2021 15:55
Failing now
1. Added `_DeterministicWrapper`. 2. Combined both masking transforms in one test.
Also test with `iid_masks=True` parameter. Should test with this param as well, since it's a different codepath. Make a batch of spectrogram by generating two spectrograms separately and concatenating them.
Addressed PR comments
mthrok
reviewed
May 12, 2021
Ensure we're going in the right codepath
|
@kiri11 Thanks! |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Holly Sweeney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1414
I combined these two transforms in one test because they're actually the same
_AxisMaskingtransform, but just on different axis. I even thought of testing the_AxisMaskingdirectly, but decided against it because it's not part of the API.Test would fail without the
_DeterministicWrapperlikely due to random behaviour here.