Fix load from file object for small files and shorter bytes #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
tweak-load-fileobj
branch
2 times, most recently
from
823265e to
07da48d
Compare
mthrok
force-pushed
the
tweak-load-fileobj
branch
4 times, most recently
from
4a1640d to
cbaa492
Compare
mthrok
changed the title
mthrok
force-pushed
the
tweak-load-fileobj
branch
3 times, most recently
from
a67210d to
dd92058
Compare
datumbox
approved these changes
Jan 27, 2021
| // * This can be changed with `torchaudio.utils.sox_utils.set_buffer_size`. | ||
| auto capacity = | ||
| (sox_get_globals()->bufsiz > 256) ? sox_get_globals()->bufsiz : 256; | ||
| std::string buffer(capacity, '\0'); |
There was a problem hiding this comment.
Perhaps there is a better type on std instead of string to define your buffer? Perhaps py::bytes?
There was a problem hiding this comment.
Looking at the implementation of py::bytes, they do not provide direct access to the underlying memory. The only way to get an access to the memory is converting it to std::string. So I think it is straightforward to use std::string
mthrok
force-pushed
the
tweak-load-fileobj
branch
from
97f4b51 to
f858a4b
Compare
mthrok
changed the title
This was referenced Jan 28, 2021
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
* Update index.rst * Delete aws_distributed_training_tutorial.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1158 file-like object support was added to
loadfunction.The code works an object that implements
readprotocolread(size: int) -> bytes.The implementation expected that the
readmethod will always returns thebyteswith the exact requested length, but that should not be required.This PR relax it with couple of tweaks.
read_fileobjhelper function that callsreadand retry until the requested length is fetched / EOF is reached.