-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor][Dataset] YesNo implementation #1127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. Please address my few comments and also please fix the style check issue.
Thanks, the code looks good. Since this PR is to aide the discussion, I will keep it as-is until we hear back on #910. (but because of the time of the year, I expect that we will not hear back very soon) If you have extra time you would like to kill, then you can work on |
@mthrok wishing you a merry Christmas and a happy new year :). |
torchaudio/datasets/yesno.py
Outdated
url: str = _RELEASE_CONFIGS["release1"]["url"], | ||
folder_in_archive: str = _RELEASE_CONFIGS["release1"]["folder_in_archive"], | ||
download: bool = False | ||
) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 is no happy when indentation for continuous line is 4 spaces, because that is visually same as logical indentation. This often happens when if
statement spans multiple lines or function indentation like this.
I think indenting 4 more spaces will resolve the issue.
def __init__(
self,
...
) -> None:
...
@krishnakalyan3 thanks, wish you a happy holidays too :) |
Co-authored-by: Nikita Shulga <[email protected]>
Implementation for the
YesNo
dataset.cc: @mthrok
Fixes: #910
The initial plan is to refactor the datasets (first part of the PR). Based on the complexity will create subsequent PRs.