Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typo in melscale_fbanks #3486

Closed
gau-nernst opened this issue Jul 20, 2023 · 1 comment
Closed

Small typo in melscale_fbanks #3486

gau-nernst opened this issue Jul 20, 2023 · 1 comment

Comments

@gau-nernst
Copy link

📚 The doc issue

In this page

https://pytorch.org/audio/main/generated/torchaudio.functional.melscale_fbanks.html

The "Returns" says

the applied result would be A * melscale_fbanks(A.size(-1), ...).

I believe the multiplication should have been matrix multiplication i.e. @

Suggest a potential alternative/fix

Change * to @. Or more explicitly, write torch.matmul()
mthrok added a commit that referenced this issue Jul 21, 2023
@mthrok
Fix typo in melscale_fbank
bf5bb2d 
Resolves #3486
@mthrok mthrok mentioned this issue Jul 21, 2023
Closed
@mthrok
Copy link
Collaborator

mthrok commented Jul 21, 2023

Fix: #3487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in melscale_fbank pytorch/audio
2 participants
@mthrok @gau-nernst