Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove F.complex_norm and T.ComplexNorm #1884

Closed
mthrok opened this issue Oct 15, 2021 · 1 comment
Closed

Remove F.complex_norm and T.ComplexNorm #1884

mthrok opened this issue Oct 15, 2021 · 1 comment

Comments

@mthrok
Copy link
Collaborator

mthrok commented Oct 15, 2021

As planned in #1337, F.complex_norm and T.ComplexNorm are now deprecated, and we can remove them.

Steps

  1. Remove the implementation

def complex_norm(

class ComplexNorm(torch.nn.Module):

  1. Remove test

@parameterized.expand(
list(itertools.product([(1, 2, 1025, 400, 2), (1025, 400, 2)], [1, 2, 0.7]))
)
def test_complex_norm(self, shape, power):
torch.random.manual_seed(42)
complex_tensor = torch.randn(*shape, dtype=self.dtype, device=self.device)
expected_norm_tensor = complex_tensor.pow(2).sum(-1).pow(power / 2)
norm_tensor = F.complex_norm(complex_tensor, power)
self.assertEqual(norm_tensor, expected_norm_tensor, atol=1e-5, rtol=1e-5)

  1. Make sure the test passes.

  2. Update docs

https://github.com/pytorch/audio/blob/25a8adf6d642bc27b156a452bc80f20741382642/docs/source/functional.rst

https://github.com/pytorch/audio/blob/25a8adf6d642bc27b156a452bc80f20741382642/docs/source/transforms.rst

Note

For setting up the development environment, please refer to CONTRIBUTING.md and torchaudio_unittest

@harishsdev
Copy link
Contributor

harishsdev commented Oct 29, 2021

@mthrok ,@nateanl ,please close this issue

@mthrok mthrok closed this as completed Nov 1, 2021
mthrok pushed a commit to mthrok/audio that referenced this issue Dec 13, 2022
* added github link to dist_overview

* added github link to dpp_tutorial

* Added github link to dist_tuto

* Added github link to FSDP_tutorial

* Added github link to process_group_cpp_extension_tutorial

* Added github link for rpc_tutorial

* Added github link to rpc_param_server_tutorial

* Added github link to dist_pipeline_parallel_tutorial

* Added github link to rpc_async_execution

* Added github link to rpc_dpp_tutorial

* Added github link to generic_join
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants