-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use glob in datasets instead of walk_files #1051
Labels
Comments
Shouldn't the globs be sorted for reproducibility reasons? |
Yes, tests should catch if the order is not consistent, see also comment. (Added |
4 tasks
Closed
Closed by #1109 |
mthrok
pushed a commit
to mthrok/audio
that referenced
this issue
Dec 13, 2022
Co-authored-by: holly1238 <[email protected]>
mpc001
pushed a commit
to mpc001/audio
that referenced
this issue
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Replace walk_files+filter in datasets by globing,
tedliumExample (noted in discussion):
torchaudio.datasets.utils.walk_files
.cc #910
The text was updated successfully, but these errors were encountered: