-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalized
argument in griffinlim is not used
#1007
Comments
I'd suggest we add a warning if it is changed from the default value, and we can remove it in a subsequent version. |
I would like to work on this. Would something like the below be okay?
Added here |
We should give one release of warning. We've just released 0.7, so this message will be visible in 0.8. We can then remove in 0.9 :) Let's put the warning at the beginning of the function call, here. And we should also provide instructions on how to suppress the warning. I suggest something like this:
Please feel free to open a pull request for this, thanks! :) |
* Update torchvision_tutorial.rst * Update torchvision_tutorial.rst Co-authored-by: holly1238 <[email protected]>
* test ghstack [ghstack-poisoned] * Update base for Update on "[PT-D] Add an example for Megatron-LM style example" [ghstack-poisoned] * Update base for Update on "[PT-D] Add an example for Megatron-LM style example" [ghstack-poisoned] * Update base for Update on "[PT-D] Add an example for Megatron-LM style example" [ghstack-poisoned] * Update base for Update on "[PT-D] Add an example for Megatron-LM style example" [ghstack-poisoned] * [PT-D] Add an example for Megatron-LM style example (pytorch#1006) * [PT-D] Add an example for Megatron-LM style example [ghstack-poisoned] * Update on "[PT-D] Add an example for Megatron-LM style example" [ghstack-poisoned]
This reverts commit 9ba53df.
🐛 Bug
F.griffinlim
'snormalized
func arg is not used. It should be removed or used.If removing it, it should also be removed from
T.GriffinLim
.The text was updated successfully, but these errors were encountered: