Skip to content

Commit

Permalink
Sync fbcode (#996)
Browse files Browse the repository at this point in the history
fbshipit-source-id: 4fb853c391900d3070b936e5a3e4609eb78a780d

* 20200428 pytorch/audio import

Summary: [10:30:47: cpuhrsch@devvm3140 pytorch]$ ./fb_build/import_audio.sh

Reviewed By: vincentqb

Differential Revision: D21282421

fbshipit-source-id: 9bde1455ca6a19defbf33dbbfc5f0d49a8e4dc6a

* Import torchaudio 20200528

Summary: Import Up to #664

Reviewed By: cpuhrsch

Differential Revision: D21728204

fbshipit-source-id: 648dd622087fa762194ca5f89a310500e777263d

* Remove unnecessary config file from torchaudio

Summary: Turned out .use_external_sox is not necessary for building torchaudio in fbcode.

Reviewed By: vincentqb

Differential Revision: D21792939

fbshipit-source-id: c0fb5173c6533e67114f50ddc8e9425bd129574f

* Import torchaudio 20200605

Summary: import torchaudio 0.5.0 in fbcode using import_audio.sh:

Reviewed By: vincentqb

Differential Revision: D21884426

fbshipit-source-id: b6f2cc308e597caef2dd767c315b167c09fb0d4c

* Change parameterized testing system to be compatible with unittest

Summary: The previous implementation of parameterized testing worked by modifying test.common_utils inplace.  This doesn't work in general because unittest's contract with test modules is such that it must be able to load the module and run the test itself.  Because the previous implementation needed to load the module and modify it, it is incompatible.

Reviewed By: mthrok

Differential Revision: D21964676

fbshipit-source-id: 9bb71e8c3f9fab074239b22306f3bbddb0f3975b

* Import torchaudio 20200618 #718

Summary: Import torchaudio up to #719

Reviewed By: zhangguanheng66

Differential Revision: D22119491

fbshipit-source-id: e14842278a32c9373179fc132e8111a0ffe66d93

* Import torchaudio 20200714 #782 (#784)

Summary:
Pull Request resolved: #784

 - Import torchaudio.
 - Change test util module name from test_case_utils to case_utils

Reviewed By: cpuhrsch

Differential Revision: D22261638

fbshipit-source-id: eb4df500c1d7db0a60baa100dd22795a63851438

* remediation of S205607

fbshipit-source-id: 5113fe0c527595e4227ff827253b7414abbdf7ac

* remediation of S205607

fbshipit-source-id: 798decc90db4f13770e97cdce3c0df7d5421b2a3

* Import torchaudio 20200723

Summary: Import torchaudio 20200723 #814

Reviewed By: fmassa

Differential Revision: D22666393

fbshipit-source-id: 50df07b5c158fe4e95ada7ea54381b2e26f6aecd

* Support custom exception message (#41907)

Summary:
Raise and assert used to have a hard-coded error message "Exception". User provided error message was ignored. This PR adds support to represent user's error message in TorchScript.

This breaks backward compatibility because now we actually need to script the user's error message, which can potentially contain unscriptable expressions. Such programs can break when scripting, but saved models can still continue to work.

Increased an op count in test_mobile_optimizer.py because now we need aten::format to form the actual exception message.

This is built upon an WIP PR:  pytorch/pytorch#34112 by driazati

Pull Request resolved: pytorch/pytorch#41907

Reviewed By: ngimel

Differential Revision: D22778301

Pulled By: gmagogsfm

fbshipit-source-id: 2b94f0db4ae9fe70c4cd03f4048e519ea96323ad

* Import torchaudio 20200804

Summary: Up to #804

Reviewed By: vincentqb

Differential Revision: D22947671

fbshipit-source-id: d1a005cec2f1a00913c41eda380b9f4b993ef779

* Remove .python3 markers

Reviewed By: ashwinp-fb

Differential Revision: D22955630

fbshipit-source-id: f00ef17a905e4c7cd9196c8924db39f9cdfe8cfa

* Import torchaudio 20200821

Reviewed By: cpuhrsch

Differential Revision: D23273584

fbshipit-source-id: 2fe7effa11b7f7cdf0cee1da6b1cac5556e9f55b

* Import torchaudio 20200922

Summary: Up to #914

Reviewed By: vincentqb, cpuhrsch

Differential Revision: D23846718

fbshipit-source-id: 9feb4e58563b900965467bd9ff66c979211c50df

* replace max-sentences with batch-size for dependencies

Summary: this fixes some regressions introduced by D24121305. fairseq configuration is changing from command line to dataclasses (via hydra eventually) which no longer supports option aliases. one such alias is --max-sentences / --batch-size, and D24121305 removed --max-sentences as --batch-size is more appropriate (fairseq is not just an nlp framework dealing with sentences). unfortunately it seems some existing flows broke and this diff attempts to fix this

Differential Revision: D24142488

fbshipit-source-id: 075180ea10a9d706a3f8d64b978d66dfd83c3d2b

Co-authored-by: Vincent Quenneville-Belair <[email protected]>
Co-authored-by: cpuhrsch <[email protected]>
Co-authored-by: Ji Chen <[email protected]>
Co-authored-by: Ben Mehne <[email protected]>
Co-authored-by: Stanislau Hlebik <[email protected]>
Co-authored-by: Yanan Cao <[email protected]>
Co-authored-by: Andres Suarez <[email protected]>
Co-authored-by: Alexei Baevski <[email protected]>
  • Loading branch information
9 people authored Nov 2, 2020
1 parent 23804a3 commit 758f6c2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion examples/interactive_asr/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def setup_asr(args, logger):
check_args(args)
import_user_module(args)

if args.max_tokens is None and args.max_sentences is None:
if args.max_tokens is None and args.batch_size is None:
args.max_tokens = 30000
logger.info(args)

Expand Down

0 comments on commit 758f6c2

Please sign in to comment.