[not for land] hardcoded two-stage reduction for max(abs(tensor)) #1205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Based on investigations around
pytorch/pytorch#128063, changing the user code to do the tensorwise max in two steps helps the compiler find better fusion opportunities.
TBD on if we want to land this or have torch.compile do this automatically, but for now putting up a PR to make this easier to explore/benchmark.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: