Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[not for land] hardcoded two-stage reduction for max(abs(tensor)) #1205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 31, 2024

Summary:

Based on investigations around
pytorch/pytorch#128063, changing the user code to do the tensorwise max in two steps helps the compiler find better fusion opportunities.

TBD on if we want to land this or have torch.compile do this automatically, but for now putting up a PR to make this easier to explore/benchmark.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:

Based on investigations around
pytorch/pytorch#128063, changing the user code
to do the tensorwise max in two steps helps the compiler find better
fusion opportunities.

TBD on if we want to land this or have torch.compile do this
automatically, but for now putting up a PR to make this easier to
explore/benchmark.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Oct 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1205

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 2ec4979 with merge base d252612 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants