Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Restructure of benchmark files to tools #879

Merged
merged 1 commit into from
Feb 20, 2022
Merged

refactor: Restructure of benchmark files to tools #879

merged 1 commit into from
Feb 20, 2022

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Feb 17, 2022 •
edited
Loading

Signed-off-by: Anurag Dixit [email protected]

Description

Re structured the python perf benchmark suite. Moved it to tools

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@andi4191 andi4191 requested a review from narendasan February 17, 2022 23:47
@andi4191 andi4191 self-assigned this Feb 17, 2022
@andi4191 andi4191 mentioned this pull request Feb 17, 2022
Closed
6 tasks
github-actions[bot]
github-actions bot approved these changes Feb 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Feb 17, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

narendasan
narendasan approved these changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 7223fc8 into master Feb 20, 2022
@andi4191 andi4191 deleted the anuragd/benchmark_reorg branch February 24, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan narendasan approved these changes

Assignees

@andi4191 andi4191

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andi4191 @narendasan