Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support aten::Int #548

Merged
merged 1 commit into from
Jul 28, 2021
Merged

feat: support aten::Int #548

merged 1 commit into from
Jul 28, 2021

Conversation

inocsin
Copy link
Contributor

@inocsin inocsin commented Jul 28, 2021

Description

aten::Int.float is missing in evalutors, and there are some models need this evalutor

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
    support aten::Int.float, aten::Int.bool

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

narendasan
narendasan approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit fc6ae24 into pytorch:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inocsin @narendasan