Require full compilation arg #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
narendasan
reviewed
Oct 1, 2024
| @@ -107,6 +107,8 @@ def _pretraced_backend( | |||
| torchtrt_inputs = prepare_inputs( | |||
| torch_inputs, disable_memory_format_check=True | |||
| ) | |||
| if settings.require_full_compilation: | |||
| raise AssertionError("this argument is only applicable for ir=dynamo") | |||
There was a problem hiding this comment.
I think this isnt very clear since the backend will get called from torch.compile. You could instead throw a warning that requires_full_compilation does nothing for the tensorrt backend for torch.compile
There was a problem hiding this comment.
I changed this to a warning. But should there be some additional logic to make this argument invalid for the backend = "torch_tensorrt" since it would still be passed to the same partitioning code, and error out in case of torch.compile if there is a graph break
apbose
force-pushed
the
require_full_compilation_arg
branch
2 times, most recently
from
a654911
to
191f20f
Compare
narendasan
reviewed
Oct 7, 2024
| @@ -107,6 +107,10 @@ def _pretraced_backend( | |||
| torchtrt_inputs = prepare_inputs( | |||
| torch_inputs, disable_memory_format_check=True | |||
| ) | |||
| if settings.require_full_compilation: | |||
| logger.warning( | |||
| "req_full_compilation arg is not applicable for torch.compile with backend='torch_tensorrt" | |||
There was a problem hiding this comment.
Use the actual name of the argument require_full_compilation
add arg require_full_compilation
apbose
force-pushed
the
require_full_compilation_arg
branch
from
191f20f
to
e21852a
Compare
lanluo-nvidia
added a commit
that referenced
this pull request
Oct 8, 2024
…2.5 (#3213) Co-authored-by: apbose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3177