Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lluo/fix merge issue #3162

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Lluo/fix merge issue #3162

merged 3 commits into from
Sep 15, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

fix merge issue

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review September 15, 2024 22:56
@lanluo-nvidia
Copy link
Collaborator Author

since it is a mistake during merge and I need to get the tag build started, merge it in without approval during weekend, will let @narendasan know on Monday.

@lanluo-nvidia lanluo-nvidia merged commit 6717ddc into release/2.5 Sep 15, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants