Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dynamic shape support for pdist ops #3068

Merged
merged 2 commits into from
Aug 8, 2024
Merged

chore: dynamic shape support for pdist ops #3068

merged 2 commits into from
Aug 8, 2024

Conversation

keehyuna
Copy link
Collaborator

@keehyuna keehyuna commented Aug 7, 2024

Description

np.triu_indices(dim0, k=1) is implemented by index calculation in loop layer when dim0 is dynamic shape

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@keehyuna keehyuna requested a review from chohk88 August 7, 2024 04:25
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 7, 2024
@keehyuna keehyuna self-assigned this Aug 7, 2024
keehyuna
keehyuna commented Aug 7, 2024
View reviewed changes
py/torch_tensorrt/dynamo/conversion/impl/normalization/ops.py
@@ -417,20 +421,21 @@ def pdist(
) -> Union[TRTTensor, Sequence[TRTTensor]]:
shape = input.shape
# Extend input from shape [N, D] to [N, 1, D]
extend_input = impl.shuffle.reshape(
extend_input = impl.unsqueeze.unsqueeze(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same functionality. it's changed to handle when all shapes are dynamic shape

zewenli98
zewenli98 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations. LGTM

peri044
peri044 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 8ecc809 into pytorch:main Aug 8, 2024
37 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@zewenli98 zewenli98 zewenli98 approved these changes

@chohk88 chohk88 Awaiting requested review from chohk88

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@keehyuna keehyuna

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keehyuna @peri044 @zewenli98 @facebook-github-bot