Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relax thresholds of dynamo converters' tests #3061

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

After bumping to TRT 10, some Dynamo converters' tests in Torch-TRT failed due to threshold/tolerance issue. TRT team suggests using 5e-3 as the threshold.

Fixes #3053

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Aug 5, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label Aug 5, 2024
@narendasan
Copy link
Collaborator

Change the TS tests as well

@zewenli98 zewenli98 merged commit 1fc1b39 into main Aug 23, 2024
55 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature] Relax thresholds in tests for TRT 10 upgrade
3 participants