Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic support for pixel_suffle and pixel_unshuffle #3044

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented Jul 26, 2024

Description

Support dynamic shapes for aten.pixel_suffle and aten.pixel_unshuffle.

The overall logic is the same as before, but now shape information is retrieved using add_shape, and additional TensorRT operations are used as needed. As shown in the test cases, it fully supports dynamic shapes for all dimensions.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88 chohk88 self-assigned this Jul 26, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 26, 2024
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/shuffle.py Outdated Show resolved Hide resolved
@chohk88 chohk88 requested a review from zewenli98 August 6, 2024 08:36
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chohk88 chohk88 merged commit 648772c into main Aug 7, 2024
41 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants