Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bug fixes for full and expand #3019

Merged
merged 5 commits into from
Jul 31, 2024
Merged

chore: bug fixes for full and expand #3019

merged 5 commits into from
Jul 31, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Jul 18, 2024

Description

Fixes #3016

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 18, 2024
@github-actions github-actions bot requested a review from gs-olive July 18, 2024 21:52
@peri044 peri044 mentioned this pull request Jul 18, 2024
Closed
lanluo-nvidia
lanluo-nvidia approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@lanluo-nvidia lanluo-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: core Issues re: The core compiler component: runtime labels Jul 20, 2024
@Hukongtao
Copy link

Will this PR be merged and have a corresponding nightly version in the near future?

@peri044
Copy link
Collaborator Author

peri044 commented Jul 31, 2024

Verified on local. Merging this.

@peri044 peri044 merged commit 4476792 into main Jul 31, 2024
21 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanluo-nvidia lanluo-nvidia lanluo-nvidia approved these changes

@gs-olive gs-olive Awaiting requested review from gs-olive

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: runtime component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] TRT Error when compiling ViT with Dynamic Shape
4 participants
@peri044 @Hukongtao @lanluo-nvidia @facebook-github-bot