Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dynamic shape for aten.linear #3011

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented Jul 16, 2024

Description

Dynamic shape support for aten.linear

When using torch.randn for weight initialization, an assertion error occurs.

AssertionError: Tensor-likes are not close! 
Mismatched elements: 323 / 2304 (14.0%)
Greatest absolute difference: 0.015128374099731445 at index (1, 1, 139) (up to 0.001 allowed) 
Greatest relative difference: 3.242828845977783 at index (1, 1, 154) (up to 0.001 allowed)

However, no error occurs with torch.rand initialization.
This is likely due to a numerical error, but I haven't pinpointed the exact cause yet.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88 chohk88 requested a review from peri044 July 16, 2024 07:44
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 16, 2024
@github-actions github-actions bot requested a review from narendasan July 16, 2024 07:44
@chohk88 chohk88 requested review from apbose, keehyuna and lanluo-nvidia and removed request for narendasan July 16, 2024 07:44
@chohk88 chohk88 self-assigned this Jul 16, 2024
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you open a github issue with the torch.randn error testcase ?

@chohk88
Copy link
Collaborator Author

chohk88 commented Jul 19, 2024

LGTM. Can you open a github issue with the torch.randn error testcase ?

I have created a linked bug issue and included steps to reproduce the error in the issue description. Consequently, I have removed unnecessary comments from the code.

@chohk88 chohk88 merged commit e359c5a into main Jul 24, 2024
19 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Numerical error with dynamic shape support for aten.linear
3 participants