Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic support for eq/ne/lt/le #2979

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented Jul 2, 2024

Description

Add dynamic shape for eq/ne/lt/le for Tensor and Scalar operations.

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88 chohk88 added the component: converters Issues re: Specific op converters label Jul 2, 2024
@chohk88 chohk88 self-assigned this Jul 2, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths and removed component: converters Issues re: Specific op converters labels Jul 2, 2024
@chohk88
Copy link
Collaborator Author

chohk88 commented Jul 8, 2024

@lanluo-nvidia @keehyuna @apbose @peri044 The existing converter already supports dynamic shapes, so I have added test cases to verify this functionality. Could you please review it?

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit bf0bc00 into main Jul 8, 2024
65 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants