Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dynamic shape support for clamp/min/max/floor_div/logical_and #2977

Merged
merged 4 commits into from
Jul 9, 2024
Merged

chore: dynamic shape support for clamp/min/max/floor_div/logical_and #2977

merged 4 commits into from
Jul 9, 2024

Conversation

keehyuna
Copy link
Collaborator

@keehyuna keehyuna commented Jul 2, 2024

Description

add dynamic shape support for clamp/min/max/floor_div/logical_and

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 2, 2024
@keehyuna keehyuna self-assigned this Jul 2, 2024
@github-actions github-actions bot requested a review from peri044 July 2, 2024 06:53
keehyuna
keehyuna commented Jul 2, 2024
View reviewed changes
tests/py/dynamo/partitioning/test_dynamic_partitioning.py Outdated
@@ -53,51 +50,6 @@ def forward(self, x):
1,
f"Number of TRT segments should be 1 but got {trt_segments}",
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case with assume_dynamic_shape_support=True flag was removed. TestDynamicPartitioning test checks if there is only trt segment in module.

peri044
peri044 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment

tests/py/dynamo/partitioning/test_dynamic_partitioning.py Outdated Show resolved Hide resolved
zewenli98
zewenli98 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 33d2c36 into pytorch:main Jul 9, 2024
55 of 61 checks passed
cehongwang pushed a commit that referenced this pull request Jul 12, 2024
@keehyuna @cehongwang
chore: dynamic shape support for clamp/min/max/floor_div/logical_and (#…
9fd312f 
…2977)
@keehyuna keehyuna deleted the clamp_dynamic_shape branch August 19, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HolyWu HolyWu HolyWu left review comments

@peri044 peri044 peri044 approved these changes

@zewenli98 zewenli98 zewenli98 approved these changes

@chohk88 chohk88 Awaiting requested review from chohk88

Assignees

@keehyuna keehyuna

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keehyuna @HolyWu @peri044 @zewenli98 @facebook-github-bot